feat(standings): use new table design in swiss standings#7294
Open
ElectricalBoy wants to merge 14 commits intomainfrom
Open
feat(standings): use new table design in swiss standings#7294ElectricalBoy wants to merge 14 commits intomainfrom
ElectricalBoy wants to merge 14 commits intomainfrom
Conversation
ElectricalBoy
added
c: standings
stylesheets
hjpalpha
reviewed
Mar 23, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
don't they get an overhaul soon anyways
ElectricalBoy
force-pushed
the
swiss-standings-use-label
branch
from
0574474 to
e85554b
Compare
ElectricalBoy
force-pushed
the
swiss-standings-use-label
branch
from
e85554b to
ca6c46c
Compare
Collaborator
Author
this basically is the first baby step of that overhaul |
Rathoz
reviewed
Mar 25, 2026
Rathoz
reviewed
Mar 25, 2026
Rathoz
reviewed
Mar 25, 2026
Eetwalt
reviewed
Mar 26, 2026
hjpalpha
reviewed
Mar 27, 2026
Rathoz
reviewed
Mar 30, 2026
| "no-duplicate-selectors": null, | ||
| "function-url-no-scheme-relative": null, | ||
| "declaration-no-important": null, | ||
| "function-disallowed-list": [], |
Collaborator
Author
There was a problem hiding this comment.
Lua-Modules/stylesheets/commons/Label.scss
Line 134 in 383fe86
wikimedia config has rgb() in disallowed list, but this PR needs it for relative colors
Contributor
There was a problem hiding this comment.
I'm not sure why wikimedia disallows this. Maybe you can try hsl()? If not then should be fine to change the config
liquidely
reviewed
Mar 30, 2026
| color: var( --placement-text-color ); | ||
| background-color: var( --placement-solid-color ); | ||
|
|
||
| --placement-text-color: var( --clr-secondary-100, #ffffff ); |
Contributor
There was a problem hiding this comment.
You can remove the second argument, right? Since this variable always exists
liquidely
reviewed
Mar 30, 2026
| --placement-text-color: var( --clr-secondary-100, #ffffff ); | ||
|
|
||
| .theme--dark & { | ||
| --placement-text-color: var( --clr-secondary-9, #181818 ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #7256
How did you test this change?
https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox + browser dev tools